Implement bitwise XOR operator (#)
#3430
Conversation
github-actions
bot
added
logical-expr
There was a problem hiding this comment.
Thank you @askoa -- this is a great first contribution
In terms of documentation it seems we are missing all the bitwise operators in https://github.com/apache/arrow-datafusion/blob/master/docs/source/user-guide/expressions.md
perhaps you could it (it would be fine to do as a follow on PR)
| Operator::BitwiseXor, | ||
| Int64Array, | ||
| DataType::Int64, | ||
| vec![9i64, 4i64, 6i64] |
There was a problem hiding this comment.
I created a issue to track this. I will update the documents. |
alamb
changed the title
#)
Codecov Report
@@ Coverage Diff @@
## master #3430 +/- ##
==========================================
- Coverage 85.63% 85.62% -0.01%
==========================================
Files 296 296
Lines 54469 54501 +32
==========================================
+ Hits 46642 46665 +23
- Misses 7827 7836 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks again @askoa |
|
Benchmark runs are scheduled for baseline = deea8c3 and contender = 8df5496. 8df5496 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3420
Are there any user-facing changes?
I think inclusion of bitwise XOR is a user-facing change.
Not sure if any documentation change is required. I mimicked a similar PR #1876. If any documentation update is required, then reviewers can point me to the documentation changes required.